Make destroy respect the abstraction#35
Open
treeowl wants to merge 1 commit intomichaelt:masterfrom
treeowl:destroy-safely
Open
Make destroy respect the abstraction#35treeowl wants to merge 1 commit intomichaelt:masterfrom treeowl:destroy-safely
treeowl wants to merge 1 commit intomichaelt:masterfrom
treeowl:destroy-safely
Conversation
`destroy` was defined exactly the same as `destroyExposed`, allowing users to distinguish between streams depending on their `Effect` layering. Now I *believe* it hides this implementation detail properly. Fixes #34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
destroywas defined exactly the same asdestroyExposed,allowing users to distinguish between streams depending on their
Effectlayering. Now I believe it hides this implementationdetail properly.
Fixes #34